Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(refactor): modify interface check way #3855

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

demoManito
Copy link
Contributor

@demoManito demoManito commented Feb 26, 2024

@demoManito demoManito changed the title Interface checks: go.dev/doc/effective_go#blank_implements optimize: interface check Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.49%. Comparing base (3dc1cd6) to head (290f7c0).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3855      +/-   ##
==========================================
+ Coverage   99.21%   99.49%   +0.28%     
==========================================
  Files          42       43       +1     
  Lines        3182     2968     -214     
==========================================
- Hits         3157     2953     -204     
+ Misses         17        9       -8     
+ Partials        8        6       -2     
Flag Coverage Δ
?
-race ∅ <ø> (?)
-tags "sonic avx" 99.42% <ø> (?)
-tags go_json 99.49% <ø> (?)
-tags nomsgpack 99.48% <ø> (?)
go-1.18 99.35% <ø> (+0.23%) ⬆️
go-1.19 99.49% <ø> (+0.27%) ⬆️
go-1.20 99.49% <ø> (+0.27%) ⬆️
go-1.21 99.36% <ø> (+0.15%) ⬆️
go-1.22 99.49% <ø> (?)
macos-latest 99.49% <ø> (+0.28%) ⬆️
ubuntu-latest 99.36% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@demoManito
Copy link
Contributor Author

image

The error reported by ci should have nothing to do with the modification.

@demoManito demoManito changed the title optimize: interface check optimize: modify interface check way Feb 26, 2024
@appleboy appleboy changed the title optimize: modify interface check way chore(refactor): modify interface check way Mar 6, 2024
@appleboy appleboy added this to the v1.10 milestone Mar 6, 2024
@appleboy appleboy merged commit 3ea8bd9 into gin-gonic:master Mar 6, 2024
55 checks passed
@appleboy
Copy link
Member

appleboy commented Mar 6, 2024

@demoManito Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants