Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated comments for Get function for params #2756

Merged
merged 1 commit into from
Jun 23, 2021
Merged

updated comments for Get function for params #2756

merged 1 commit into from
Jun 23, 2021

Conversation

imaskm
Copy link
Contributor

@imaskm imaskm commented Jun 20, 2021

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integration systems such as TravisCI.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

@appleboy appleboy added this to the v1.8 milestone Jun 23, 2021
@appleboy appleboy merged commit a8857ed into gin-gonic:master Jun 23, 2021
thinkerou added a commit that referenced this pull request Jun 24, 2021
@wei840222 @youzeliang
@imaskm @laojianzi @thinkerou @appleboy @ItalyPaleAle
gin.Context with fallback value from gin.Context.Request.Context() (#…
7834a03 
…2751)

* Update tree.go (#2659)

delete more "()"

* updated comments for Get function for params (#2756)

* ci: add github action workflows (#2596)

* ci: add github action workflows

* test: fixed the TestUnixSocket test on windows (#20)

* ci: add github action workflows (#18)

* Remove .travis.yml

* ci: replace GITTER_ROOM_ID and upload coverage every time you go test

* ci: update coverage using codecov/codecov-action@v1

* Merge branch 'master' into github-actions

* repo: replace travis ci to github actions

* ci: add go version 1.16

* fix: go install requires a specific version

* chore(ci): remove go 1.12 support

* chore(ci): remove os windows-latest

Co-authored-by: thinkerou <[email protected]>
Co-authored-by: Bo-Yi Wu <[email protected]>

* Setting trusted platform using an enum-like (#2739)

* gin.Context with fallback value from c.Request.Context()

* add test case

Co-authored-by: youzeliang <[email protected]>
Co-authored-by: Ashwani <[email protected]>
Co-authored-by: Jeff <[email protected]>
Co-authored-by: thinkerou <[email protected]>
Co-authored-by: Bo-Yi Wu <[email protected]>
Co-authored-by: Alessandro (Ale) Segala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
document
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
2 participants
@imaskm @appleboy