-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support binding for slice/array obj [Rewrite] #2302
Support binding for slice/array obj [Rewrite] #2302
Conversation
@thinkerou @appleboy I have rewritten for review issues in #2194 |
Codecov Report
@@ Coverage Diff @@
## master #2302 +/- ##
==========================================
+ Coverage 98.47% 98.49% +0.01%
==========================================
Files 41 41
Lines 1973 1989 +16
==========================================
+ Hits 1943 1959 +16
Misses 17 17
Partials 13 13
Continue to review full report at Codecov.
|
c29edbb
to
023a72b
Compare
@wuhuizuo Please fix the conflicts. |
done. |
binding/binding_test.go
Outdated
@@ -1181,6 +1195,21 @@ func testBodyBinding(t *testing.T, b Binding, name, path, badPath, body, badBody | |||
assert.Error(t, err) | |||
} | |||
|
|||
feature/array_support_for_json_bind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SYNTAX ERROR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry! it's fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
LGTM but build fail in go master version. See the report: https://travis-ci.org/github/gin-gonic/gin/jobs/742947069 |
support usage followed:
this pull is rewritten for https://github.com/gin-gonic/gin/pull/2194, avoid to change the validator interface