Improvements and more begginer-friendly README #1709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have updated the file to make it easier for beginners to get started, and also fixed some weird things.
samueldcs
changed the title
appleboy
requested changes
Dec 25, 2018
| @@ -81,14 +83,13 @@ $ go get -u github.com/gin-gonic/gin | |||
| ```go | |||
| import "github.com/gin-gonic/gin" | |||
| ``` | |||
|
|
|||
| 3. (Optional) Import `net/http`. This is required for example if using constants such as `http.StatusOK`. | |||
| 3. (Optional) Import `net/http`. This is required if you want to use constants such as `http.StatusOK`. | |||
There was a problem hiding this comment.
add an empty line before "```".
| @@ -2035,8 +2042,7 @@ func TestPingRoute(t *testing.T) { | |||
| ``` | |||
|
|
|||
| ## Users | |||
|
|
|||
| Awesome project lists using [Gin](https://github.com/gin-gonic/gin) web framework. | |||
| List of awesome projects made with the [Gin](https://github.com/gin-gonic/gin) web framework. | |||
There was a problem hiding this comment.
Add an empty line after ## Users
|
and please also check errors from Travis |
Codecov Report
@@ Coverage Diff @@
## master #1709 +/- ##
==========================================
+ Coverage 99.4% 99.42% +0.01%
==========================================
Files 42 42
Lines 2029 2073 +44
==========================================
+ Hits 2017 2061 +44
Misses 9 9
Partials 3 3
Continue to review full report at Codecov.
|
thinkerou
approved these changes
Mar 1, 2019
|
@samueldcs thanks! closing, please see #1793 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the file to make it easier for beginners to get started, and also fixed some weird things.