Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change HTML input tags to use HTML5 syntax. #1617

Merged
merged 2 commits into from
Nov 1, 2018

Conversation

jbampton
Copy link
Contributor

@jbampton jbampton commented Oct 31, 2018

In XHTML, the tag must be properly closed, like this <input />. In HTML5 the <input> tag has no ending slash. https://www.w3schools.com/tags/tag_input.asp

@codecov
Copy link

codecov bot commented Oct 31, 2018

Codecov Report

Merging #1617 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1617      +/-   ##
==========================================
- Coverage   99.47%   99.27%   -0.21%     
==========================================
  Files          36       39       +3     
  Lines        1918     1931      +13     
==========================================
+ Hits         1908     1917       +9     
- Misses          6       10       +4     
  Partials        4        4
Impacted Files Coverage Δ
errors.go 100% <0%> (ø) ⬆️
mode.go 90.9% <0%> (ø) ⬆️
render/json_17.go 100% <0%> (ø)
response_writer_1.8.go 0% <0%> (ø)
context_17.go 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fb21a8...e757d0d. Read the comment docs.

In XHTML, the <input> tag must be properly closed, like this `<input />`.  In HTML5 the `<input>` tag has no ending slash.  https://www.w3schools.com/tags/tag_input.asp
@appleboy appleboy merged commit 6f7fe48 into gin-gonic:master Nov 1, 2018
@jbampton jbampton deleted the patch-1 branch November 1, 2018 09:57
justinfx pushed a commit to justinfx/gin that referenced this pull request Nov 3, 2018
In XHTML, the <input> tag must be properly closed, like this `<input />`.  In HTML5 the `<input>` tag has no ending slash.  https://www.w3schools.com/tags/tag_input.asp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants