Update readme about the version of gin #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1494 +/- ##
=======================================
Coverage 99.15% 99.15%
=======================================
Files 36 36
Lines 1894 1894
=======================================
Hits 1878 1878
Misses 13 13
Partials 3 3Continue to review full report at Codecov.
|
thinkerou
reviewed
Aug 17, 2018
| @@ -100,7 +100,7 @@ $ mkdir -p $GOPATH/src/github.com/myusername/project && cd "$_" | |||
|
|
|||
| ```sh | |||
| $ govendor init | |||
| $ govendor fetch github.com/gin-gonic/gin@v1.2 | |||
| $ govendor fetch github.com/gin-gonic/gin@v1.3 | |||
There was a problem hiding this comment.
@thinkerou
I was going to change it into v1.3.0, but I read the doc of govendor, like below
govendor fetch golang.org/x/net/context@v1 # Get latest v1.*.* tag or branch.
And I have try v1.3, it is ok.
So I think v1.3 is better than v1.3.0
There was a problem hiding this comment.
@chainhelen you are right, because govendor have version and versionExact.
thinkerou
approved these changes
Aug 17, 2018
salamer
pushed a commit
to salamer/gin
that referenced
this pull request
Aug 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little change in readme, nothing about code.