-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Switch from govendor to dep #1128
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1128 +/- ##
=======================================
Coverage 96.68% 96.68%
=======================================
Files 16 16
Lines 1721 1721
=======================================
Hits 1664 1664
Misses 49 49
Partials 8 8 Continue to review full report at Codecov.
|
@javierprovecho @tboerger Please help to review this. |
Avoid pulling in any external example dependencies, when using go get. Go tools ignore folders with names which start with `_`.
dep is a dependency management tool for Go, slated to be the official one.
Maybe we should wait for vgo: https://research.swtch.com/vgo |
Any progress ? |
aditional info: vgo required semver tag to contain levels of version, the current 1.2 does not check in vgo currently vgo will only match with 1.1.4 |
Any progress ? |
Closing this PR as it is very much out of date and there is no indication that this would be accepted. |
@sudo-suhas thank you work, I think we may use vgo later on. |
ref #1569 |
dep
is slated to be the official Go dependency management tool. It is ready for production use. This PR switches fromgovendor
todep
. I also renamed theexamples
folders to_examples
so that the dependencies are not pulled in bydep
.Packages used by examples removed from vendor:
Almost all other dependency revisions were changed to more recent commits:
v1.0.3
)v0.0.3
)v1.1.4
)release-branch.go1.7
)v8.18.1
)v8.18.2
)Note: The revision was not changed for the package
github.com/gin-contrib/sse
.