Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print error when --all-features is used #233

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Conversation

philipc
Copy link
Contributor

@philipc philipc commented Jun 2, 2020

Fixes #232

@philipc philipc requested a review from fitzgen June 2, 2020 10:10
@philipc philipc mentioned this pull request Jun 2, 2020
@matprec
Copy link

matprec commented Jun 2, 2020

This error is swamped among 1428 other errors, as the rest of the code still is type checked. For this to be visible, all modules would need to be #[cfg(not(feature = cargo-all))] in some way

@matprec
Copy link

matprec commented Jun 2, 2020

Maybe something like this to reduce noise:

pub use modules::*;
#[cfg(not(feature = cargo-all))]
mod modules {
     pub mod foo;
     mod bar;
}

@philipc
Copy link
Contributor Author

philipc commented Jun 2, 2020

It's the first error. I'm not keen on adding further workarounds for this. rust-analyzer is disabling that setting anyway.

@matprec
Copy link

matprec commented Jun 2, 2020

Fair enogh :) Looks good to me

@philipc philipc merged commit 6df79bd into gimli-rs:master Jun 3, 2020
@philipc philipc deleted the all branch June 3, 2020 08:27
mcbegamerxx954 pushed a commit to mcbegamerxx954/object that referenced this pull request Jun 15, 2024
Print error when --all-features is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rustc integration setup
3 participants