Update ertIPManager.py #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ERTIPManager I added the option to run a pure ERT inversion. I think this is useful to be able to make sure that the resistivity model is good before running the IP inversions. Before my change, this was not possible, because the invert() function in ERTIPManager was overwriting the invert() function in ERTManager, and there is no way of constructing an ERTIPManager object directly from an ERTManager object. Creating an invertDC function seemed to me the simplest solution...
|
Indeed a good idea as one will probably first optimize the parameters of the DC inversion before proceeding to IP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ERTIPManager I added the option to run a pure ERT inversion. I think this is useful to be able to make sure that the resistivity model is good before running the IP inversions. Before my change, this was not possible, because the invert() function in ERTIPManager was overwriting the invert() function in ERTManager, and there is no way of constructing an ERTIPManager object directly from an ERTManager object. Creating an invertDC function seemed to me the simplest solution...
Frist of all, thank you for submitting a pull request. We appreciate that
you follow the spirit of open-source and that you are willing to contribute to
pyGIMLi. Please make sure that this PR is targeted to the
devbranch. If not,please change this
now.
Additional notes on development can be found on
pygimli.org/dev.