Fix iteration number in pre/postStep #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Absolutely! We are counting from 0 in Python, but in inverse theory But instead of writing |
prisae
added a commit
to prisae/gimli
that referenced
this pull request
Jun 10, 2024
In here, I fixed the iteration number: gimli-org#643 In here, the iterator was changed from `range(maxIter) to `range(1, maxIter)`, without changing back PR643, making the thing wrong again. gimli-org@d72b828
halbmy
pushed a commit
that referenced
this pull request
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the
setPreStepandsetPostStepcalls get a wrong iteration number in the inversion framework. This tiny PR should fix this.