Added an option to select a custom context to match moment-timezone l… #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilmoreorless
approved these changes
Jan 31, 2021
Comment on lines
-177
to
+186
| // Invalid cache dir (not a valid path) | ||
| if ('cacheDir' in options) { | ||
| try { | ||
| path.parse(options.cacheDir); | ||
| } catch (error) { | ||
| throwInvalid(`Provided cacheDir is an invalid path: '${options.cacheDir}'`); | ||
| // Check options that require a valid path | ||
| ['cacheDir'].forEach(option => { | ||
| if (option in options) { | ||
| try { | ||
| path.parse(options[option]); | ||
| } catch (error) { | ||
| throwInvalid(`Provided ${option} is an invalid path: '${options[option]}'`); | ||
| } | ||
| } | ||
| } | ||
| }); |
There was a problem hiding this comment.
Thanks, your code inspired me ;)
| @@ -31,7 +31,7 @@ describe('instantiation', () => { | |||
| ); | |||
| }); | |||
|
|
|||
| // TOOD: Warn instead of throw? | |||
| // TODO: Warn instead of throw? | |||
There was a problem hiding this comment.
I'm sorry for this 😅. Please don't be ashamed, I do much worse. I fixed it just because else code analysis doesn't pick it up and never warns that there is a TODO somewhere to work on. Everything is great!
There was a problem hiding this comment.
Oh I don't mind at all. I'm just amazed that I spent so much time looking at that code over the years and never spotted it! 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ocation. Fixes #32.