Skip to content

Commit

Permalink
Remove mostly-redundant test build
Browse files Browse the repository at this point in the history
component_test_CID_no_debug was added specifically to be a non-regression
test for Mbed-TLS#3998. Running compat.sh
in the newly introduced config-ccm-psk-dtls1_2.h is also a non-regression
test for that bug. Therefore component_test_CID_no_debug is redundant for
its primary purpose.

Of course every configuration is different, but the additional coverage from
component_test_CID_no_debug is minimal, unlike config-ccm-psk-dtls1_2.h
which is a plausible real-world configuration.

In mbedtls-2.28, component_test_CID_no_debug was never added, and running
the unit tests in that configuration does not trigger the Mbed-TLS#3998 bug, only
compat.sh does. So, rather than backport component_test_CID_no_debug to
2.28.2, I am removing it from 3.2.

Signed-off-by: Gilles Peskine <[email protected]>
  • Loading branch information
gilles-peskine-arm committed Apr 13, 2022
1 parent 2ecf4ff commit 5417d48
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions tests/scripts/all.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2239,18 +2239,6 @@ component_test_variable_ssl_in_out_buffer_len_CID () {
tests/compat.sh
}

component_test_CID_no_debug() {
msg "build: Connection ID enabled, debug disabled"
scripts/config.py unset MBEDTLS_DEBUG_C
scripts/config.py set MBEDTLS_SSL_DTLS_CONNECTION_ID

CC=gcc cmake .
make

msg "test: Connection ID enabled, debug disabled"
make test
}

component_test_ssl_alloc_buffer_and_mfl () {
msg "build: default config with memory buffer allocator and MFL extension"
scripts/config.py set MBEDTLS_MEMORY_BUFFER_ALLOC_C
Expand Down

0 comments on commit 5417d48

Please sign in to comment.