Build: add node 23 and fix non x64 bug

giggio · Oct 23, 2024 · e9315a0 · e9315a0
1 parent 74a42e2
commit e9315a0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -40,7 +40,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: ["18.x", "20.x", "22.x"]
+        node: ["18.x", "20.x", "22.x", "23.x"]
         runner: ["windows-latest", "ubuntu-latest", "macos-latest"]
     steps:
       - uses: actions/checkout@v4
@@ -102,10 +102,10 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: ["20", "22"]
+        node: ["20", "22", "23"]
     steps:
       - uses: actions/checkout@v4
-      - uses: uraimo/run-on-arch-action@v2.7.1
+      - uses: uraimo/run-on-arch-action@v2.8.1
         name: Verify install
         id: build
         with:
@@ -146,10 +146,10 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: ["18", "20", "22"]
+        node: ["18", "20", "22", "23"]
     steps:
       - uses: actions/checkout@v4
-      - uses: uraimo/run-on-arch-action@v2.7.1
+      - uses: uraimo/run-on-arch-action@v2.8.1
         name: Verify install
         id: build
         with:

diff --git a/testInstall.js b/testInstall.js
@@ -6,7 +6,7 @@ const os = require('os');
 const path = require('path');
 const fs = require('fs');
 const spawnSync = require('child_process').spawnSync;
-const versions = ['18', '20', '22'];
+const versions = ['18', '20', '22', '23'];
 const tempInstallPath = path.resolve(os.tmpdir(), 'chromedriver-test');
 const packedFile = path.resolve(tempInstallPath, 'chromedriver.tgz');