Explicitly set lint checks

.sync.yml

@@ -28,6 +28,14 @@ Gemfile:
       - gem: 'github_changelog_generator'
         version: '~> 1.15'
         condition: "Gem::Version.new(RUBY_VERSION.dup) >= Gem::Version.new('2.3.0')"
+      - gem: 'puppet-lint-file_ensure-check'
+        require: false
+      - gem: 'puppet-lint-manifest_whitespace-check'
+        require: false
+      - gem: 'puppet-lint-trailing_comma-check'
+        require: false
+      - gem: 'puppet-lint-optional_default-check'
+        require: false
     ':test':
       - gem: 'puppet_metadata'
         version: '~> 1.0'
@@ -37,3 +45,34 @@ spec/spec_helper.rb:
     - 'RSpec.configure do |c|'
     - '  c.facter_implementation = :rspec'
     - 'end'
+.puppet-lint.rc:
+  enabled_lint_checks:
+    - 140chars
+    - 2sp_soft_tabs
+    - arrow_alignment
+    - class_inherits_from_params_class
+    - double_quoted_strings
+    - duplicate_params
+    - file_ensure
+    - file_mode
+    - hard_tabs
+    - leading_zero
+    - manifest_whitespace_opening_brace_after
+    - nested_classes_or_defines
+    - only_variable_string
+    - optional_default
+    - parameter_documentation
+    - parameter_order
+    - parameter_types
+    - quoted_booleans
+    - right_to_left_relationship
+    - slash_comments
+    - star_comments
+    # - strict_indent
+    - trailing_comma
+    - trailing_whitespace
+    - unquoted_file_mode
+    - variable_contains_dash
+    - variable_is_lowercase
+    - variable_scope
+    - variables_not_enclosed

Gemfile

@@ -25,6 +25,9 @@ group :development do
   gem "puppet-module-win-default-r#{minor_version}", '~> 1.0',   require: false, platforms: [:mswin, :mingw, :x64_mingw]
   gem "puppet-module-win-dev-r#{minor_version}", '~> 1.0',       require: false, platforms: [:mswin, :mingw, :x64_mingw]
   gem "github_changelog_generator", '~> 1.15',                   require: false if Gem::Version.new(RUBY_VERSION.dup) >= Gem::Version.new('2.3.0')
+  gem "puppet-lint-file_ensure-check",                           require: false
+  gem "puppet-lint-manifest_whitespace-check",                   require: false
+  gem "puppet-lint-trailing_comma-check",                        require: false
 end
 group :system_tests do
   gem "puppet-module-posix-system-r#{minor_version}", '~> 1.0', require: false, platforms: [:ruby]

manifests/config.pp

@@ -6,7 +6,7 @@
   assert_private()
 
   file { $osquery::config_path:
-    ensure       => present,
+    ensure       => file,
     owner        => $osquery::config_owner,
     group        => $osquery::config_group,
     mode         => '0640',

manifests/init.pp

@@ -56,7 +56,6 @@
   Optional[String] $repo_key_server            = undef,
   Hash $settings                               = {},
 ) {
-
   contain osquery::package
   contain osquery::config
   contain osquery::service

manifests/package.pp

@@ -15,7 +15,7 @@
           key      => {
             id     => $osquery::repo_key_id,
             server => $osquery::repo_key_server,
-          }
+          },
         }
 
         Package<|title == $osquery::package_name|> {

pdk.yaml

@@ -0,0 +1,2 @@
+---
+ignore: []