fix(misconf): fix infer type for null value (aquasecurity#7424)

Signed-off-by: nikpivkin <[email protected]>
giantswarm · Dec 20, 2024 · 604d36a · 604d36a
1 parent 5a3e397
commit 604d36a
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/pkg/iac/scanners/cloudformation/cftypes/types.go b/pkg/iac/scanners/cloudformation/cftypes/types.go
@@ -15,6 +15,9 @@ const (
 )
 
 func TypeFromGoValue(value any) CfType {
+	if value == nil {
+		return Unknown
+	}
 	switch reflect.TypeOf(value).Kind() {
 	case reflect.String:
 		return String

diff --git a/pkg/iac/scanners/cloudformation/parser/parser_test.go b/pkg/iac/scanners/cloudformation/parser/parser_test.go
@@ -419,3 +419,24 @@ func TestJsonWithNumbers(t *testing.T) {
 	assert.Equal(t, 1, res[0].GetProperty("SomeIntProp").AsIntValue().Value())
 	assert.Equal(t, 0, res[0].GetProperty("SomeFloatProp").AsIntValue().Value())
 }
+
+func TestParameterIsNull(t *testing.T) {
+	src := `---
+AWSTemplateFormatVersion: 2010-09-09
+
+Parameters:
+  Email:
+    Type: String
+
+Conditions:
+  SubscribeEmail: !Not [!Equals [ !Ref Email, ""]]
+`
+
+	fsys := testutil.CreateFS(t, map[string]string{
+		"main.yaml": src,
+	})
+
+	files, err := New().ParseFS(context.TODO(), fsys, ".")
+	require.NoError(t, err)
+	require.Len(t, files, 1)
+}