-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change kyverno-policy-operator and exception-recommender namespaces on legacy #178
Conversation
This is only needed until we release exception-recommender changing the defaults:
|
I agree with the namespace change, but tell me more about not creating it. It's just for the one use case we discussed already right? What about creating a policyexception for that use case and keeping the namespace creation? Or what's the plan for all the other clusters? |
We don't want the app to create the namespace because it will already be created by the bundle. If exception-recommender tries to create it through its chart it will fail to install since the namespace will already exist. Namespace creation is a feature from exception-recommender that is meant to be used only when you are creating the Drafts in another namespace. In this case they will both live together. |
Where is it created by the bundle? |
I mean that since the installation namespace will be Not by the bundle itself but by the helm client as part of the chart install. |
Ok got it, and IIUC this behavior (to create the namespaces or not) is configured at the app-operator level, but the helm client will still be using chart-operator's service account. So if/when KPO and ExRec move into other namespaces we'll have to handle creating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo, but LGTM
Co-authored-by: Zach Stone <[email protected]>
This PR changes the default namespace from
security-bundle
topolicy-exceptions
forkyverno-policy-operator
andexception-recommender
apps.