Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrape limited policy-reporter metrics from WCs #1570

Closed
wants to merge 7 commits into from
Closed

Scrape limited policy-reporter metrics from WCs #1570

wants to merge 7 commits into from

Conversation

stone-z
Copy link
Contributor

@stone-z stone-z commented Mar 14, 2024 •
edited
Loading

Towards https://github.com/giantswarm/giantswarm/issues/29351
Replaces #1477

Checklist

I have:

  • Described why this change is being introduced
  • Separated out refactoring/reformatting in a dedicated PR
  • Updated changelog in CHANGELOG.md

@stone-z stone-z self-assigned this Mar 14, 2024
@stone-z stone-z mentioned this pull request Mar 14, 2024
Closed
3 tasks
QuentinBisson
QuentinBisson approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@QuentinBisson QuentinBisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The general idea is to move away from this scrape config but you don't have a choice now

@stone-z
Copy link
Contributor Author

stone-z commented Mar 14, 2024

Yeah I'll be happy to ditch it. giving this a quick test on gaia before merging.

side note -- when deploying a branch of PMO, it tries to pull from docker, but the dev branch CI doesn't push to docker. Is that known? I had to edit the deployment to pull from quay

@QuentinBisson
Copy link
Contributor

No I was not

stone-z and others added 5 commits March 20, 2024 11:20
@stone-z
Change polr metric
2e8605c
@stone-z
Merge branch 'master' into polr-merge
f46925c
@stone-z
Regenerate tests
fa725e5
@stone-z @QuentinBisson
@taylorbot @uvegla
Merge master into polr changes (#1578)
9fb99c8 
* Fix labelling schemas (#1571)

* Release v4.70.3 (#1573)

* Bump version to 4.70.4-dev (#1574)

* Remove azure provider (#1572)

* Add Team Honeybadger Slack (#1575)

* Release v4.71.0 (#1576)

* Bump version to 4.71.1-dev (#1577)

* Regenerate tests

---------

Co-authored-by: Quentin Bisson <[email protected]>
Co-authored-by: Taylor Bot <[email protected]>
Co-authored-by: Laszlo Uveges <[email protected]>
@stone-z
Merge branch 'polr-merge' into scrape-wc-polr
eeba379
@stone-z
Copy link
Contributor Author

stone-z commented Mar 20, 2024

With the change to Kyverno's report structure, we would need to scrape the result series in order to associate the policy state with the name of the policy. However, that series is much noisier than the summary series, and we'd need to scrape and store a bunch of unnecessary information.
Until grafana/alloy#554 (or maybe prometheus/prometheus#394 ?) is implemented, which I believe would allow us to drop the unnecessary data at scrape time instead, I don't think we can proceed here.

@stone-z stone-z closed this Mar 20, 2024
@Gacko Gacko deleted the scrape-wc-polr branch September 17, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuentinBisson QuentinBisson QuentinBisson approved these changes

Assignees

@stone-z stone-z

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stone-z @QuentinBisson