Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use networking Ingress API #18

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Use networking Ingress API #18

merged 1 commit into from
Oct 7, 2020

Conversation

sslavic
Copy link

@sslavic sslavic commented Oct 6, 2020

NGINX IC 0.40.0 drops support for validating extensions/v1beta1 Ingress resources. Validating webhook is enabled by default in NGINX IC App. Although it's not absolutely necessary to have validating webhook enabled in performance tests, it helps to have it enabled for both ensuring load test initial state correctness and also serves as functional integration test.
Some more details in giantswarm/ingress-nginx-app#122 and changelog.

Assuming this gets merged and released, @piontec I'll need your help to update dependency and release https://github.com/giantswarm/pytest-helm-charts

@sslavic sslavic requested a review from a team October 6, 2020 13:05
@sslavic sslavic self-assigned this Oct 6, 2020
@sslavic
Copy link
Author

sslavic commented Oct 7, 2020

Tested on gauss. Going with a ping

@sslavic sslavic merged commit cfdbce2 into master Oct 7, 2020
@sslavic sslavic deleted the ingress-networking-api branch October 7, 2020 08:12
@piontec
Copy link

piontec commented Oct 14, 2020

Shit, sorry, I missed this PR. LGTM. Let's release it, then updating pytest-helm-chart should be as easy as change the image version and run the testing suite (unless there's something else involved I missed - let me know).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants