Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NGINX IC 0.40.0 drops support for validating
extensions/v1beta1
Ingress resources. Validating webhook is enabled by default in NGINX IC App. Although it's not absolutely necessary to have validating webhook enabled in performance tests, it helps to have it enabled for both ensuring load test initial state correctness and also serves as functional integration test.Some more details in giantswarm/ingress-nginx-app#122 and changelog.
Assuming this gets merged and released, @piontec I'll need your help to update dependency and release https://github.com/giantswarm/pytest-helm-charts