Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce prematurely dropped deprecated config properties #36

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

sslavic
Copy link

@sslavic sslavic commented Mar 11, 2020

Towards https://github.com/giantswarm/giantswarm/issues/9379

These config properties were dropped in #26, released in nginx IC App v1.4.0.

@sslavic sslavic requested review from a team March 11, 2020 22:22
@sslavic sslavic self-assigned this Mar 11, 2020
@sslavic sslavic force-pushed the reintroduce-config-options branch 2 times, most recently from ee9fb52 to 9b0afb5 Compare March 11, 2020 23:20
@sslavic sslavic force-pushed the reintroduce-config-options branch from 9b0afb5 to 59d27ef Compare March 12, 2020 00:34
@sslavic
Copy link
Author

sslavic commented Mar 12, 2020

Tested on gauss

@sslavic sslavic merged commit ee0dc48 into master Mar 12, 2020
@sslavic sslavic deleted the reintroduce-config-options branch March 12, 2020 01:10
@sslavic sslavic mentioned this pull request Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants