Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update controller container image to v1.4.0. #353

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Update controller container image to v1.4.0. #353

merged 2 commits into from
Oct 17, 2022

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Oct 17, 2022

Closes https://github.com/giantswarm/giantswarm/issues/23642.

Tests on workload clusters (not always required)

For changes in the chart, chart templates, and ingress controller container images, I executed the following tests
to verify them working in live enviromnents:

Test / Provider AWS Azure KVM
Upgrade from previous version
Existing Ingress resources are reconciled correctly
Fresh install
Fresh Ingress resources are reconciled correctly

Testing was done using hello-world-app.

Hint for KVM:

kubectl port-forward -n kube-system svc/nginx-ingress-controller-app 8080:80
ingress_domain=host.configured.in.ingress; curl --connect-to "$ingress_domain:80:127.0.0.1:8080" "http://$ingress_domain" -v

@Gacko Gacko requested a review from a team as a code owner October 17, 2022 13:35
@Gacko Gacko enabled auto-merge (squash) October 17, 2022 14:40
Copy link
Member

@ubergesundheit ubergesundheit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please also document what to do if 1.3.1 is skipped

@Gacko Gacko merged commit 0067861 into master Oct 17, 2022
@Gacko Gacko deleted the feature/v1.4.0 branch October 17, 2022 14:49
@webwurst
Copy link
Contributor

@Gacko
Copy link
Member Author

Gacko commented Oct 17, 2022

Hm, ok. Will have a look at this tomorrow. I'll postpone the release of v2.19.0 for now. Already added a note about the migration to Lease API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants