Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace hub with gh #648

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Replace hub with gh #648

merged 2 commits into from
Oct 5, 2023

Conversation

mcharriere
Copy link
Contributor

@mcharriere mcharriere commented Oct 5, 2023 •
edited
Loading

  • Replace hub CLI with the official gh tool.
  • update changelog

Checklist

  • Update changelog in CHANGELOG.md.

@mcharriere
Replace hub CLI with the official gh tool.
33b4c26 
`hub` has been removed from the runner-images
actions/runner-images#8362

Signed-off-by: Matias Charriere <[email protected]>
@mcharriere
update changelog
99633c7 
Signed-off-by: Matias Charriere <[email protected]>
@mcharriere mcharriere requested a review from a team as a code owner October 5, 2023 10:34
@mcharriere mcharriere changed the title replace hub with gh Replace hub with gh Oct 5, 2023
ubergesundheit
ubergesundheit approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@ubergesundheit ubergesundheit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcharriere mcharriere merged commit 2efe8ef into main Oct 5, 2023
1 check passed
@mcharriere mcharriere deleted the replace-hub-with-gh branch October 5, 2023 10:37
marians
marians approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@marians marians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubergesundheit ubergesundheit ubergesundheit approved these changes

@marians marians marians approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcharriere @marians @ubergesundheit