Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

Bump kubernetes version and use Giantswarm image repo #200

Merged
merged 2 commits into from
Jan 30, 2023

Conversation

bdehri
Copy link

@bdehri bdehri commented Jan 30, 2023

What this PR does / why we need it

In order to update kubernetes, we need to change imageRepository as coredns image path is not calculated correctly.

Checklist

  • Update changelog in CHANGELOG.md.

Trigger e2e tests

/test create
/test upgrade

@tityosbot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@bdehri
Copy link
Author

bdehri commented Jan 30, 2023

/test all

@tityosbot
Copy link

@bdehri: No jobs can be run with /test all.
The following commands are available to trigger jobs:

  • /test create
  • /test upgrade

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bdehri bdehri self-assigned this Jan 30, 2023
@bdehri
Copy link
Author

bdehri commented Jan 30, 2023

/test create
/test upgrade

@bdehri
Copy link
Author

bdehri commented Jan 30, 2023

Should we do anything about these values?
https://github.com/giantswarm/cluster-gcp/blob/main/helm/cluster-gcp/values.yaml#L56

  etcd:
    imageRepository: "docker.io/giantswarm"
    imageTag: 3.5.4-0-k8s

@bdehri bdehri marked this pull request as ready for review January 30, 2023 10:19
@bdehri bdehri requested a review from a team January 30, 2023 10:19
@bdehri
Copy link
Author

bdehri commented Jan 30, 2023

As per our discussion, For etcd, We decided to remove image repository and keep image tag.

@bdehri
Copy link
Author

bdehri commented Jan 30, 2023

/retest

@fiunchinho
Copy link
Member

I think retest does not work

/test create
/test upgrade

@bdehri bdehri merged commit 9c07c42 into main Jan 30, 2023
@bdehri bdehri deleted the registryandk8supdate branch January 30, 2023 12:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants