Add metrics for karpenter machines and KubeadmConfigs #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiunchinho
force-pushed
the
karpenter-machines
branch
from
50df779
to
3651989
Compare
fiunchinho
changed the title
fiunchinho
force-pushed
the
karpenter-machines
branch
from
0cc9f23
to
06b9f21
Compare
fiunchinho
force-pushed
the
karpenter-machines
branch
from
06b9f21
to
6d60f59
Compare
Gacko
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/giantswarm/giantswarm/issues/32111
We need this version bump to get the karpenter machine metrics working, because version 2.7.0 was affected by this bug, which prevents the app from generating metrics from two CRDs with the same name, and we have CAPI Machines and karpenter Machines.
Checklist
values.yamlandvalues.schema.jsonare valid.