This repository has been archived by the owner on Oct 30, 2024. It is now read-only.
Update cluster-autoscaler permissions #3650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvix
approved these changes
Nov 10, 2023
AndiDog
approved these changes
Nov 13, 2023
whites11
approved these changes
Nov 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Cluster Autoscaler 1.24.x upstream introduced an early no capacity check for AWS node groups.
This requires an additional IAM permission which we don’t have in the instance profile for
master nodes.
autoscaling:DescribeScalingActivitiesThey didn’t mention it in the release notes of 1.24.0 as a requirement, but they changed the docs quoting this permission is one of the bare minimum permissions for a functional autoscaler.
Checklist