-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for EOL Python 2.6 #1178
Conversation
Can you change this so that set literals are not used? This way psutil can still be imported on python 2.6. Basically I'm looking to implement the original #1053 plan. |
Done! |
@@ -85,11 +85,10 @@ exe/wheel installers hosted on | |||
If you want to compile psutil from sources you'll need **Visual Studio** | |||
(Mingw32 is no longer supported): | |||
|
|||
* Python 2.6, 2.7: `VS-2008 <http://www.microsoft.com/en-us/download/details.aspx?id=44266>`__ | |||
* Python 3.3, 3.4: `VS-2010 <http://www.visualstudio.com/downloads/download-visual-studio-vs#d-2010-express>`__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why remove instructions for 2.7 and 3.4?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, mistaken removal of 2.7 along with 2.6, and 3.4 is still there, just 3.3 removed.
@@ -29,6 +29,7 @@ | |||
import threading | |||
import time | |||
import traceback | |||
import unittest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of doing this can you please change all other test files and import unittest
directly instead of from psutil.test import unittest
?
Actually I retract, sorry. I think it is better to hold off on this a little while longer. Stats for Python 2.6 show 1% usage add 29,737 downloads in the last 30 days, which is about 30x times Python 3.3 usage.
|
Those numbers include mirrors too. How are they with the --pip switch? |
|
👍 Thanks, more or less the same. Just let me know if/when you're ready for updates to this. |
Thank you and sorry for wasting your time. I'll ping you for sure when the time comes. |
Just to keep an eye on the trend, here's the pip installs from PyPI for July 2018:
Source: ( (Really nice to see Python 3 now accounts for 60%! Up from 12% in October!) |
#1053 says to drop Python 2.6 support in unit tests and scripts, and to issue a deprecation warning in psutil.
In case or until you want to go further, this also removes Python 2.6 code, plus already dropped 3.2-3.3.