Support loading certificates from macOS keychain #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires optional build tag "certstore" to be set because karalabe/xgo doesn't support darwin-10.12 (only up to 10.11) for cross-compilation, and mastahyeti/certstore requires 10.12 minimum.
mcpherrinm
approved these changes
Jun 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support loading certificates from macOS keychain using certstore.
Can be used like this, e.g. if the test-keys/client keystore is imported into the macOS keychain:
Note that this requires
-tags certstoreon build, and only compiles with that flag enabled on macOS 10.12+. The build tag is required as xgo can only target up to macOS 10.11 on cross-compile, and the necessary APIs are not available there. Also this is "experimental" and I haven't really tested it very well besides ensuring that the basic functionality works.