Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix older adwaita tab bars appearing above the title bar #5410

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

danudey
Copy link
Contributor

@danudey danudey commented Jan 28, 2025

When setting up the GTK window with older Adwaita versions, we need to explicitly create and add a tab bar. The previous code simply prepended the tab bar into the GtkBox, which resulted in it being the very first element (ahead of the title bar).

Instead, we grab a reference to the GTK title bar widget and call gtk_box_insert_child_after() to explicitly insert our tab bar into the hierarchy just after the title bar.

@mitchellh mitchellh enabled auto-merge January 29, 2025 14:55
@mitchellh mitchellh merged commit d31e6c8 into ghostty-org:main Jan 29, 2025
30 checks passed
@github-actions github-actions bot added this to the 1.1.0 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants