macOS: add link to release notes on appcast #5184
Merged
+9
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4730
I opted to link directly to the release notes of the updated version in the
<description>body, i.e. in the future it would link directly v1.0.2's release notes at https://ghostty.org/docs/install/release-notes/1-0-2. This thereby implements the second option mentioned in the issue. It wasn't that much harder than the third option, but if there's any particular reason not to link directly to a version's changelog page, I'll be more than happy to modify this PR and implement the third option instead - in any case, I had opened ghostty-org/website#277 so that https://ghostty.org/docs/install/release-notes is a valid page.I also wrapped the current text
<![CDATA[ ... ]]>just in case, as I noticed this is a pretty standard practice in other apps that use<description>to embed their release notes when using Sparkle - Sparkle's documentation says to do this so you can use unescaped HTML.