don't error when gtk4 could not be found via pkg-config #4546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jan200101
added a commit
to Jan200101/ghostty
that referenced
this pull request
Jan 6, 2025
this prevents issues with people running `zig build --help` without gtk4 installed same as ghostty-org#4546
mitchellh
added a commit
that referenced
this pull request
Jan 6, 2025
this prevents issues with people running `zig build --help` without gtk4 development stuff installed same as #4546
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
running
zig build --helpwas crashing for some people, I narrowed it down to gtk4 not being installed however that shouldn't make the help message nor should it block glfw builds