gtk(wayland): add support for background blur on KDE Plasma #4403
Conversation
pluiedev
force-pushed
the
push-vruxlyxvvwpx
branch
5 times, most recently
from
a701ca2 to
4ab0a82
Compare
There was a problem hiding this comment.
We should consider resource management here for example do we need to destroy the blur manager on close. And do we need to handle the display disconnect or does gtk do that I think you can use WAYLAND_DEBUG=1 to see the Wayland messages which should have the destroy and disconnect stuff there
You can't do that, actually. There isn't a destructor. I've looked at how winit does it (Apache 2.0 code so I think it's fine) and they only clean up the blur token.
They're all managed by GTK (GDK, to be more precise), so we don't have to worry about that at all |
pluiedev
force-pushed
the
push-vruxlyxvvwpx
branch
2 times, most recently
from
27affa9 to
2e6ddd1
Compare
pluiedev
force-pushed
the
push-vruxlyxvvwpx
branch
2 times, most recently
from
9556b3d to
47543b4
Compare
Currently the `background` CSS class is added once on startup and never removed or re-added. This is problematic as that if Ghostty was started with an opaque window but then its config was reloaded with a `background-opacity` less than 1, the window won't actually become translucent, and it would only appear as if the background colors had become faded (because the window is still styled to be opaque).
mitchellh
force-pushed
the
push-vruxlyxvvwpx
branch
from
47543b4 to
f2c357a
Compare
|
Automerge is on. Send it. |
Also establishes a foundation for Wayland support and fixes a minor bug (GTK windows remaining opaque when
background-opacityis set to 1 on startup and later updated to less than 1 with a config reload)Can't update the Zig cache hash myself since I'm currently in China and my proxy's broken for some reason :(
See also #4361, part of #4626