apprt/gtk: make window-decoration=false with gtk-titlebar=true look better #3999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etter Before this change, there seemed to be some artifacting in the window corners due to the window border no longer outlining the content properly. By detecting the situation, we can turn the window border radius off. Signed-off-by: Tristan Partin <[email protected]>
|
I'd love to provide pictures, but it is hard to capture. Any reviewer should test it for themselves. |
|
Thanks for the attention to detail. I trust you saw and fixed this. |
|
See previous discussion in #3290. |
jcollie
reviewed
Dec 30, 2024
|
@tristan957 can confirm this does fix it |
|
Fixed it for me as well. Nice! |
ndavd
added a commit
to ndavd/dotfiles
that referenced
this pull request
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, there seemed to be some artifacting in the window corners due to the window border no longer outlining the content properly. By detecting the situation, we can turn the window border radius off.