-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naive search internals (core only) #2885
Merged
+1,347
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going to merge this. This isn't in use at all yet so there's no potential harm here in a merge. I'll still be notified and read any feedback if anyone has any. Then I'll plan follow ups to keep working on this... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #189
This PR implements a simple, single-threaded, single-direction Booyer-Moore-Horspool search on top of
PageList
.The code in this PR is not utilized in builds yet. It is only part of unit tests. I want to open a PR incrementally so we don't have one mega PR for search. I want to be very clear that this does not finish #189, there's many more steps before that.
High-level technical overview: we maintain a circular buffer of UTF-8 encoded terminal page contents that is just large enough to fit the larger of a single page or the search term. As we search, the circular buffer is pruned and additional terminal pages are added to search. This minimizes our memory usage to the minimum necessary for this approach. In practice, the overhead is very small for realistic search terms!
Some limitations that need to be resolved in future work:
PageList
is not being actively modified. That's not going to work for a real final user-facing solution.