macos: quick terminal animate duration #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd accept the animation portion of this PR but not the |
futurepaul
force-pushed
the
quick-terminal-improvements
branch
from
572e36e to
3d2cc55
Compare
futurepaul
changed the title
|
Ah, my bad for not seeing that issue. Updated to only add the animate option. |
mitchellh
reviewed
Oct 25, 2024
futurepaul
force-pushed
the
quick-terminal-improvements
branch
from
3d2cc55 to
f4ba95b
Compare
futurepaul
changed the title
|
Thank you! Just waiting on CI then will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the quick terminal more closely replicate my personal "Hotkey Window" settings on iTerm2. (I've also replicated the same setup using HammerSmith and kitty, it's a big deal for me!)
These new settings are exercised by this config:
I considered making a new quick-terminal-size config item that would control the fraction of the screen the quick terminal covers (defaulting to 4) but that seemed like a more invasive change and this covers my use case.
I wasn't entirely sure about my values in
initialOriginalandfinalOriginbut this seems to work correctly in animated and non-animated modes.Happy to close this and create an issue if that would be more appropriate.