macOS: Key Sequence UI #2418
macOS: Key Sequence UI #2418
Conversation
| @@ -411,6 +411,7 @@ pub fn performAction( | |||
| .size_limit, | |||
| .cell_size, | |||
| .secure_input, | |||
| .key_sequence, | |||
There was a problem hiding this comment.
This is the action that needs to be implemented for GTK to support this.
|
Seems like this could be the beginning of a status bar element for ghostty. You could just keep the bar there permanently and the pending key could be one of the "widgets." Anyway, happy to provide an impl after the PR merges. But a GtkRevealer with a GtkBox containing a GtkLabel will probably be enough to match what you are doing with the mac impl. On libadwaita you would probably apply the On libadwaita, we might actually want to use https://gnome.pages.gitlab.gnome.org/libpanel/class.Statusbar.html. Could be a good excuse to bring in libpanel as a dependency. In the future, I see splits being created as panels in the libadwaita side of things. |
|
Sounds great. Note the GTK design doesn't need to match the macOS design at all. I'd rather do whatever looks best and most idiomatic for the platform. (I don't think this looks best or most idiomatic for macOS at all, but my lack of design skills are showing. 😄 ) |
Related to #2127 (doesn't fix since we still need a GTK UI)
This implements a UI for #2121. The most important part of this PR is the core cross-platform plumbing to get access to sequenced keybind information, not the UI itself. I think the UI itself could definitely use some love and improvement, and I'm happy for anyone to take that on. I think importantly, this gets us from no UI at all to some UI for key sequences.
This is macOS only. GTK shouldn't be hard to follow but would love any ideas (or even contributions) from our resident GTK experts, such as @jcollie @tristan957 etc.
Demo
The "pending key sequence" only shows up while a pending key sequence is active. Once a key sequence is complete (either through successfully executed an action or typing a key that isn't part of the sequence) then it disappears.