scrollback: buffer writes to scrollback file #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Screen.dumpString writes one character at a time, so buffer writes to the scrollback file to speed it up.
|
This looks great, thank you. Waiting on CI then will merge. |
|
@kdrag0n Do you give me permission to relicense this commit plus all other commits to this project you made as MIT? I need this prior to public release or will have to revert and/or rewrite your work. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.dumpString writes one character at a time, so buffer writes to the scrollback file to speed it up.
(haven't measured performance, but feels faster when there's a lot of history)