-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ghost-Windows on macOS with global toggle-visibility
keybind.
#3219
Comments
Oh, and I forgot, if Ghostty is open but has no windows, it would be awesome if the toggle visibility action could create a new window. |
cc @rolandpeelen re #2205. |
There's also incompatibility with |
fwiw, i don't experience this when toggling only the default initial window at start up. However, if i create a new window (cmd+n), close the initial one, I experience the same thing during toggle. Also if I create tabs (cmd+t) and toggle, the tabs come back as separate windows instead of tabs (installed via brew, Sequoia 15.3) |
Looks like even just opening a new tab with cmd+t on MacOS and then toggling the visibility causes this issue. It also splits the tabs and if you do it a couple of times they'll both be broken windows showing only their title bars |
The last commit seems like fixes the 'ghost windows' issue, but |
Yeah, I was thinking maybe that should be made its own issue. It probably is outside the scope of this one. |
I found there's a discussion regarding this already here: #4240 |
Fixes ghostty-org#3219 We were holding a reference cycle to the base terminal controller. This was preventing the window from ever being fully deallocated.
Thanks for building Ghostty. I'm trying to migrate from iTerm2 which has a "Show/hide all windows with a system-wide hotkey". Here is my current config:
Every time I toggle visibility, it creates a non-interactive "ghost window" behind the current window. Here, I'm toggling between iTerm and Ghostty by pressing
ctrl+y
:CleanShot.2024-12-27.at.09.45.172.mp4
Separately, when visibility is hidden using this shortcut, clicking the Ghostty icon in the macOS dock does not show the Ghostty windows until triggering toggle visibility action again.
Next, pressing the toggle visibility button sometimes creates tons of empty windows:
![Image](https://private-user-images.githubusercontent.com/13352/398820025-571dd371-8172-4c7c-abe3-6cb781b2f8ae.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMzIyNjQsIm5iZiI6MTczOTMzMTk2NCwicGF0aCI6Ii8xMzM1Mi8zOTg4MjAwMjUtNTcxZGQzNzEtODE3Mi00YzdjLWFiZTMtNmNiNzgxYjJmOGFlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDAzNDYwNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTAwMWMxNGFkYmRmMTNkNDA2MmVlNzJiOWUwMWZjMjdkZTlkZTczOWNhNGJhZWYzYzJiMDIzNWY5YzdiNjVmOGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.o6pB--LmsBivrSkf_lVYzjxujquSnA_S7w1R4HtYAo0)
Finally, when Ghostty gets into this state,
![Image](https://private-user-images.githubusercontent.com/13352/398820214-01d562ca-0de8-4b3f-8c12-58e7f0f72512.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMzIyNjQsIm5iZiI6MTczOTMzMTk2NCwicGF0aCI6Ii8xMzM1Mi8zOTg4MjAyMTQtMDFkNTYyY2EtMGRlOC00YjNmLThjMTItNThlN2YwZjcyNTEyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDAzNDYwNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEzOGY5MDNjZjRiZGFmN2EyN2JjYTgwYTQ0NjYyZTM4MmNjMGI0NmVlMzQ1NGY0Mzk3MDgxZWU2ZmRkOTI0NDImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.gkl-OIytaWQRE647VoeB51wHtauMEt1OZoPj6tfP6sg)
cmd+w
may close the session but leaves a ghost window behind:I'm using the latest versions of everything on macOS.
The text was updated successfully, but these errors were encountered: