Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quick-terminal-position: add middle for floating middle position #2494

Closed
pomdtr opened this issue Oct 25, 2024 · 1 comment · Fixed by #3100
Closed

quick-terminal-position: add middle for floating middle position #2494

pomdtr opened this issue Oct 25, 2024 · 1 comment · Fixed by #3100
Labels
contributor friendly A well-scoped, approachable issue for someone looking to contributor. os/macos

Comments

@pomdtr
Copy link
Collaborator

pomdtr commented Oct 25, 2024

I would love to be able to have the quick terminal behave like an alfred/raycast style launcher.

Maybe by adding a middle option to the quick-terminal-position config field ?

Image
@mitchellh mitchellh changed the title Launcher Layout for Quick Terminal quick-terminal-position: add middle for floating middle position Oct 27, 2024
@mitchellh mitchellh added os/macos contributor friendly A well-scoped, approachable issue for someone looking to contributor. labels Oct 27, 2024
@mitchellh
Copy link
Contributor

I like it. My suggestion, as you said but with more details:

@dmehala dmehala mentioned this issue Dec 24, 2024
Merged
mitchellh added a commit that referenced this issue Dec 25, 2024
@mitchellh
feat: add support for middle position quick terminal (#3100)
fddedd7 
# Description

This commit introduces the ability to launch the quick terminal in the
middle position.

![Screen Recording 2024-12-24 at 14 59
46](https://github.com/user-attachments/assets/6c733caf-34c7-4e80-ba16-24b41f98d2f0)

## Note to reviewer
- The quick terminal is currently centered. Should we consider adding a
top offset to better align with the screenshot in [the issue](#2494 )?
Should it be configurable?
- On large monitors, half the visible frame might be excessively large.
To mitigate, I am planning to implement #2384 but we should probably
agree on a good default maximum width/height in middle position.
- I also figured out, reloading the configuration does not update the
quick terminal configuration. That is also an issue I will try to fix.

Resolves #2494

I agree to relicense my commit to MIT.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributor friendly A well-scoped, approachable issue for someone looking to contributor. os/macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for middle position quick terminal dmehala/ghostty
2 participants
@mitchellh @pomdtr