Build is broken on Debian 12

[jneuhaus]

After pulling the most recent today:

commit 3cdb9a7dfe59fa46dde27b5ada5932bbe42094b8 (HEAD -> main, origin/main, origin/HEAD)
Merge: d1fd22ae 4e0d9b1b
Author: Mitchell Hashimoto <[email protected]>
Date:   Tue Jan 14 10:08:53 2025 -0800

    gtk(wayland): implement server-sided decorations (#4724)
    
    Fixes #4630 fully unless there exists an X11 API I haven't found yet :p
    
    ~~Depends on first commit of #4723, which is duplicated here for now~~

And then performing a build using: zig build -p $HOME/.local -Doptimize=ReleaseFast
the build fails with:

$ ./build.sh 
Already up to date.
install
└─ install ghostty
   └─ zig build-exe ghostty ReleaseFast native 1 errors
src/apprt/gtk/Window.zig:417:14: error: root struct of file 'cimport' has no member named 'adw_tab_overview_set_show_start_title_buttons'
            c.adw_tab_overview_set_show_start_title_buttons(
            ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/data/home/jos/work/github.com/ghostty/.zig-cache/o/156c20006b7ac03a49e3891279ce7075/cimport.zig:1:1: note: struct declared here
pub const __builtin_bswap16 = @import("std").zig.c_builtins.__builtin_bswap16;
^~~
referenced by:
    gtkRealize: src/apprt/gtk/Window.zig:629:9
    init: src/apprt/gtk/Window.zig:280:66
    remaining reference traces hidden; use '-freference-trace' to see all reference traces
error: the following command failed with 1 compilation errors:

[jneuhaus]

Contents of the build.sh script in the message above:

#!/usr/bin/env bash
git pull
zig build -p $HOME/.local -Doptimize=ReleaseFast

[jcollie]

What version of libadwaita? I'm guessing older than 1.3.0?

[jcollie]

If you could test this patch I'd appreciate it.

diff --git a/src/apprt/gtk/Window.zig b/src/apprt/gtk/Window.zig
index 3e972ca0..33617c98 100644
--- a/src/apprt/gtk/Window.zig
+++ b/src/apprt/gtk/Window.zig
@@ -251,10 +251,11 @@ pub fn init(self: *Window, app: *App) !void {
     };

     // If we have a tab overview then we can set it on our notebook.
-    if (self.tab_overview) |tab_overview| {
-        if (comptime !adwaita.versionAtLeast(1, 3, 0)) unreachable;
-        assert(self.notebook == .adw);
-        c.adw_tab_overview_set_view(@ptrCast(tab_overview), self.notebook.adw.tab_view);
+    if ((comptime adwaita.versionAtLeast(1, 3, 0)) and adwaita.enabled(&self.app.config)) {
+        if (self.tab_overview) |tab_overview| {
+            assert(self.notebook == .adw);
+            c.adw_tab_overview_set_view(@ptrCast(tab_overview), self.notebook.adw.tab_view);
+        }
     }

     self.context_menu = c.gtk_popover_menu_new_from_model(@ptrCast(@alignCast(self.app.context_menu)));
@@ -410,9 +411,7 @@ pub fn syncAppearance(self: *Window, config: *const configpkg.Config) !void {
     // Disable the title buttons (close, maximize, minimize, ...)
     // *inside* the tab overview if CSDs are disabled.
     // We do spare the search button, though.
-    if ((comptime adwaita.versionAtLeast(0, 0, 0)) and
-        adwaita.enabled(&self.app.config))
-    {
+    if ((comptime adwaita.versionAtLeast(1, 3, 0)) and adwaita.enabled(&self.app.config)) {
         if (self.tab_overview) |tab_overview| {
             c.adw_tab_overview_set_show_start_title_buttons(
                 @ptrCast(tab_overview),

[mitchellh]

This was fixed on main