Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically regenerate when configs change #959

Conversation

blast-hardcheese
Copy link
Contributor

Resolves #958

  • Takes all available settings
  • Renders them to equivalent CLI args
  • Uses that as a tracked input for whether to run the codegen

@@ -11,6 +11,27 @@ object CalibanSourceGenerator {
import zio._
import zio.console._

import sjsonnew.{ :*:, LList, LNil }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a dependency of sbt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, built in already. There is one downside about this approach, where if sbt breaks bincompat, it means a new release will need to be cut (or newer versions of the plugin will not be compatible with some older versions of sbt).

I haven't found a good solution for this, and this seems to be the only way to implement this functionality, so I'm at a loss other than to just raise awareness about it.

Copy link
Owner

@ghostdogpr ghostdogpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I will trust you on this 😆

@ghostdogpr ghostdogpr merged commit d1a70e3 into ghostdogpr:master Jul 9, 2021
@blast-hardcheese blast-hardcheese deleted the automatically-regenerate-when-configs-change branch July 9, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sbt plugin does not automatically evict cached files when CalibanSettings changes
2 participants