Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Play framework-related regex to codegen tool #956

Merged

Conversation

yonlugoh
Copy link
Contributor

@yonlugoh yonlugoh commented Jul 8, 2021

Expanded the regex which previously accepted only path names with /scala to also accept |play.* or |app (The issue enclosed suggested to only add play but the scastie example provided has /app in the path name instead of play)

closes #950

@yonlugoh yonlugoh changed the title Add Play framework-related regex to codegen tool WIP: Add Play framework-related regex to codegen tool Jul 8, 2021
@yonlugoh yonlugoh changed the title WIP: Add Play framework-related regex to codegen tool Add Play framework-related regex to codegen tool Jul 8, 2021
@ghostdogpr ghostdogpr requested a review from paulpdaniels July 8, 2021 22:42
Copy link
Owner

@ghostdogpr ghostdogpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! @paulpdaniels wanna have a look?

@paulpdaniels
Copy link
Collaborator

paulpdaniels commented Jul 9, 2021

Yeah I mistyped. /app is the top level route for play apps. So I don't believe we need the "play" variant just the "app" one but it shouldn't hurt

@paulpdaniels paulpdaniels merged commit 4f9a57a into ghostdogpr:master Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client Codegen doesn't handle the name properly with play projects.
3 participants