Http4s Module upload support #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
changed the title
ghostdogpr
reviewed
Jul 3, 2021
|
By the way the Play adapter is missing batching support: https://github.com/jaydenseric/graphql-multipart-request-spec#operations-2. Not sure it's something you want to handle while you're at it. |
|
@ghostdogpr thanks for a quick review, hope tomorrow I'll have time to address your comments 🚀 Actually indeed that is the portion of the code that I'm using right now, but in the future I can see this (batching) being handy. Thanks for a pointer! |
pomadchin
commented
Jul 3, 2021
|
@ghostdogpr ready for the final review! |
ghostdogpr
approved these changes
Jul 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just ports the Caliban Play module upload support.