Add support for distinguishing explicit and implicit null in ArgBuilders #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostdogpr
reviewed
Jun 17, 2021
| @@ -39,6 +43,30 @@ object Scala2SpecificSpec extends DefaultRunnableSpec { | |||
| """{"events":[{"organizationId":7,"title":"Frida Kahlo exhibition"}],"painters":[{"name":"Claude Monet","movement":"Impressionism"}]}""" | |||
| ) | |||
| ) | |||
| }, | |||
There was a problem hiding this comment.
If the test is same for Scala 2 and Scala 3, you can simply add it in the scala folder, no need to duplicate it. These files are just for Scala2 or Scala3 specific features (like Scala 3 enums).
There was a problem hiding this comment.
For some reason I though it had to be there for it to run for each version - I'll move the test.
ghostdogpr
reviewed
Jun 17, 2021
ghostdogpr
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for distinguishing between explicit null, where a
nullwas sent to an input, from implicit null, where no value was provided for an input field. It uses an approach inspired by zio-json'sJsonDecoder, adding a newbuildMissingmethod toArgBuilderthat by default callsbuildwithNullValue. The new method is called when a field is missing. This change should be backwards compatible, with no change in behavior for existingArgBuilderinstances.New
ArgBuilderinstances can override thebuildMissingmethod to customize their behavior when a value is missing and provide different behavior from whennullis supplied.