Partial union type query #446 #790
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostdogpr
reviewed
Mar 4, 2021
| """ | ||
|
|
||
| def safeUnapplyName(name: String): String = | ||
| if (reservedKeywords.contains(name) || name.endsWith("_")) s"$name$$" | ||
| if (reservedKeywords.contains(name)) s"${name}_" |
There was a problem hiding this comment.
I think there's a merge issue here, those changes should not be reverted and probably explain the CI error.
There was a problem hiding this comment.
Thanks for spotting that. I will try to update that and let you know how it goes.
There was a problem hiding this comment.
Looks like the same issue with:
[info] [error] /tmp/sbt_f9ee2458/src/main/scala/Client.scala:82:7: overriding method wait in class Object of type ()Unit;
[info] [error] value wait cannot override final member
[info] [error] wait: String
[info] [error] ^
I will look over the merge conflicts that I attempted to resolve and see if I screwed other spots up too.
anotherhale
changed the title
|
Found the merge conflicts and resolved them. Now need to resolve failing tests. I will look into that |
|
|
|
This last commit is failing to compile but I feel is closer to how it could work. Not sure how I munged up the |
|
My bad - my Scala is a bit rusty. I did resolve the |
|
Tests now pass and it looks like the appropriate Client code is generated (for the Snippet: Full Output: |
|
It fails on this schema https://github.com/ghostdogpr/caliban/blob/master/codegen-sbt/src/sbt-test/codegen/test-compile/project/schema.graphql (it also fails on the gitlab one but this one is much smaller so easier to reproduce the problem). You can run a test on that schema so you can see the code that is generated. |
Ok. I won't get to it until next week or the week after. |
|
I have a lot of higher priority issues from work and so have not been able to get any time for this. I would like to resolve it and so I will work on it outside of my work hours. I only have a few hours a week so it may take some time to resolve this. |
|
I did it in #1099 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#446
This is a work in progress. I originally worked on this last July and so I had to resolve merge conflicts. Everything compiles but when I tried to run the
scriptedtest it fails with the following;snipppet from console output:
Full output