Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the max buffersize for jsoniter #2459

Merged

Conversation

kaaveland
Copy link
Contributor

This is a first take on #2458

Let me know if there's something missing, or if I should try another way to do this.

Copy link
Collaborator

@kyri-petrou kyri-petrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also add a test case in TapirAdapterSpec that would fail using the pre-PR code? That way we can ensure that the implicits are all properly used across all adapters.

@kaaveland kaaveland force-pushed the increase-jsoniter-buffersize branch from 047afa9 to c90df59 Compare November 8, 2024 10:18
@kaaveland kaaveland force-pushed the increase-jsoniter-buffersize branch 2 times, most recently from c6db04d to f3bd899 Compare November 8, 2024 10:21
@kaaveland
Copy link
Contributor Author

kaaveland commented Nov 8, 2024

I added a test case, but it currently also fails on this branch -- we're getting 413 Request Entity Too Large from PlayAdapterSpec and QuickAdapterSpec. I'm working on figuring out how to make these two servers accept larger payloads. I did verify that it reproduces the error on series/2.x.

@kaaveland kaaveland force-pushed the increase-jsoniter-buffersize branch from f3bd899 to 50055c8 Compare November 19, 2024 09:29
@kaaveland kaaveland force-pushed the increase-jsoniter-buffersize branch from 50055c8 to 68361a0 Compare November 19, 2024 09:38
@kaaveland
Copy link
Contributor Author

@ghostdogpr want to take a new look? There's a test case that fails on main and works on the branch now. I tried to avoid using application.conf for the PlayAdapterSpec, but I was unable to make the settings stick by passing them as properties. 🤔

Copy link
Owner

@ghostdogpr ghostdogpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghostdogpr ghostdogpr merged commit fafe332 into ghostdogpr:series/2.x Nov 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants