Fix ArgBuilder derivation for case classes containing only optional fields #2408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyri-petrou
commented
Sep 17, 2024
core/src/main/scala-2/caliban/schema/ArgBuilderDerivation.scala
Outdated
Show resolved
Hide resolved
ghostdogpr
reviewed
Sep 19, 2024
core/src/main/scala-2/caliban/schema/ArgBuilderDerivation.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala-2/caliban/schema/ArgBuilderDerivation.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala-3/caliban/schema/ArgBuilderDerivation.scala
Outdated
Show resolved
Hide resolved
|
@ghostdogpr I noticed that we had some very similar logic for determining value types in SchemaDerivation. In order to avoid conflicts, I reused the same logic for both deriving schemas & arg builders |
ghostdogpr
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/fixes #2407
Issue was that we were treating all case classes as potential value types. Fix is to determine during compile-time whether the case class is a value type (either using annotations or checking if the case class extends
AnyVal)@guymers I also added the tests that were in #2403 to ensure that
oneOfinput derivation is working as expected now.