Optimize Field#allFieldsUniqueNameAndCondition
#2368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostdogpr
reviewed
Aug 20, 2024
| private[caliban] def allFieldsUniqueNameAndCondition: Boolean = | ||
| fields.isEmpty || fields.tail.isEmpty || allConditionsUniqueLzy | ||
|
|
||
| private lazy val allConditionsUniqueLzy: Boolean = { |
ghostdogpr
reviewed
Aug 20, 2024
paulpdaniels
approved these changes
Aug 24, 2024
ghostdogpr
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method exists in the very hot path of execution, so even micro-optimizations to it are quite nice.
Basically this PR does the following:
lazy valwhen we can check if the conditions are unique without iterating through the fieldsaliasedName, which also removes the need for allocating a HashSet. It just occurred to me that we if the conditions are all the same, then the names are guaranteed to be unique because otherwise we would have deduplicated them when we create the Field