Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support introspecting and client codegen of deprecated arguments #2347

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

kyri-petrou
Copy link
Collaborator

/closes #2345

Couple of remarks:

  1. I used true as the default for this option for both codegen and introspection. Should we be using false?
  2. I used a class instead of case class for IntrospectionClient.Config. This is because classes are much easier to extend without breaking binary compatibility in the future. Should we care about this since it's in tools?

@kyri-petrou kyri-petrou requested a review from ghostdogpr July 25, 2024 11:30
@kyri-petrou kyri-petrou changed the title Add support for introspecting and client generation for deprecated arguments Support introspecting and client codegen of deprecated arguments Jul 25, 2024
@ghostdogpr
Copy link
Owner

ghostdogpr commented Jul 26, 2024

  1. I used true as the default for this option for both codegen and introspection. Should we be using false?

I think it should be false to not break anything.

  1. I used a class instead of case class for IntrospectionClient.Config. This is because classes are much easier to extend without breaking binary compatibility in the future. Should we care about this since it's in tools?

I know there's a caliban-mill library that uses tools, maybe some people have custom CI scripts as well. Maybe we just avoid breaking the codegen interface and it should be enough.

@ghostdogpr
Copy link
Owner

Wait, I made supportRepeatable true by default? 🤣 Let's be consistent with old me then.

@kyri-petrou
Copy link
Collaborator Author

Wait, I made supportRepeatable true by default? 🤣 Let's be consistent with old me then.

Yeah I actually had it set to false initially and changed it afterwards to be consistent 😆

@kyri-petrou kyri-petrou merged commit 8a5ba12 into series/2.x Jul 27, 2024
10 checks passed
@kyri-petrou kyri-petrou deleted the support-deprecated-args-tools branch July 27, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated arguments are missing in introspection query
2 participants