Add method to "suspend" wrappers and reimplement APQs #2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyri-petrou
added
the
breaking change
ghostdogpr
reviewed
Jul 1, 2024
federation/src/test/scala/caliban/federation/tracing/FederationTracingSpec.scala
Outdated
Show resolved
Hide resolved
|
I reverted the changes to the methods with Clock implicits, and also reverted the deletion of |
kyri-petrou
removed
the
breaking change
kyri-petrou
commented
Jul 1, 2024
| @@ -272,51 +268,6 @@ object WrappersSpec extends ZIOSpecDefault { | |||
| } | |||
| ) | |||
| }, | |||
| test("Apollo Caching") { | |||
There was a problem hiding this comment.
I won't revert this one, just to make it easier to delete the file in the next major release
ghostdogpr
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should have made this PR prior to the 2.8.0 release, but I guess it'll have to wait till 2.9.0 🥲
Main changes in this PR:
Wrapper.suspendwhich allows "suspending" side effects used in the construction of a Wrapper. This works the same way asEffectfulWrapperbut without having to use ZIO for itEffectfulWrapperas the type returned from the different methods, we can't change them without breaking binary compatibility.Wrapper[Any]instead ofWrapper[ApolloPersistence]. There are a few reasons for this, but mainly this is because it makes it quite annoying to integrate this wrapper in non-ZIO applications, especially if the users are not familiar with ZLayers and how to eliminate dependencies from the environment. Users now have 2 ways to use this wrapper:ApolloPersistedQueries.wrapper, which will create a new instance ofApolloPersistence.Liveand reuse it for all queriesApolloPersistedQueries.wrapper(???)which allows users to provide a customApolloPersistenceimplementation