Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return Exit for methods in Pagination #2298

Merged
merged 2 commits into from
Jun 23, 2024
Merged

Return Exit for methods in Pagination #2298

merged 2 commits into from
Jun 23, 2024

Conversation

kyri-petrou
Copy link
Collaborator

We could easily also return Either as well, but at least Exit is source-compatible

@kyri-petrou kyri-petrou requested a review from ghostdogpr June 23, 2024 08:24
@ghostdogpr
Copy link
Owner

Looks good but there are some compile errors

@kyri-petrou kyri-petrou merged commit 0f760dc into series/2.x Jun 23, 2024
10 checks passed
@kyri-petrou kyri-petrou deleted the pagination-args-exit branch June 23, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghostdogpr ghostdogpr ghostdogpr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyri-petrou @ghostdogpr