-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build.sbt cleanup #2276
build.sbt cleanup #2276
Conversation
Remove explicit ZIO test framework as it is built into sbt. Remove snapshot resolvers to avoid depending on snapshots. Remove scala-xml v1 workaround as it is no longer required.
I am not sure what happened but both your PRs seem to not have triggered the CI 🤔 |
I'm a bit conflicted about removing the snapshot repository from |
How about using Global Settings? |
Yeah dunno, pushed again and now it seems to be running |
It's a nice workaround but in some cases it's useful to be able to use it for draft PRs as well (e.g., #2251). I'm not against removing it though, but if we can have a fairly decent way to keep it for dev/PRs and disable it for the main branch that'd be ideal AFAICT |
How about leaving it commented out then? |
Yeah I think that should be fine 👍 |
Remove explicit ZIO test framework as it is built into sbt.
Remove snapshot resolvers to avoid depending on snapshots.
Remove scala-xml v1 workaround as it is no longer required.